Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider overriden url on cli formatting #3356

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: consider overriden url on cli formatting #3356

merged 1 commit into from
Nov 14, 2023

Conversation

danielbdias
Copy link
Contributor

This PR fixes #3352, where the CLI don't consider the -s flag when formatting test output.

Changes

  • Added EndpointOverriden virtual config

Fixes

  • Updated config UI() method to consider overridden endpoint

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias merged commit a27be36 into main Nov 14, 2023
38 checks passed
@danielbdias danielbdias deleted the fix/cli-url-bug branch November 14, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI don't consider -s when building url on test output
2 participants
@danielbdias @xoscar