Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dynamic Collector Config #3372

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat: Dynamic Collector Config #3372

merged 2 commits into from
Nov 21, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Nov 17, 2023 •
edited
Loading

This PR adds a way to support dynamic collector configurations by exporting the constants as functions and having a separate map for them

Changes

  • Adds customizable HOC for ingestor and collector config

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Nov 17, 2023
@xoscar xoscar requested a review from jorgeepc November 17, 2023 17:09
@xoscar xoscar marked this pull request as ready for review November 17, 2023 17:12
@xoscar xoscar merged commit 0a7cab1 into main Nov 21, 2023
38 checks passed
@xoscar xoscar deleted the fix/collector-configurations branch November 21, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc