Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cypress trigger type #3439

Merged
merged 3 commits into from
Dec 14, 2023
Merged

feat: add cypress trigger type #3439

merged 3 commits into from
Dec 14, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Dec 13, 2023 •
edited
Loading

This PR adds support for the new cypress trigger type

Changes

  • cypress trigger type

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/d4662bcb02f848b7b6044a8215a0a706?sid=675e193e-7184-4dad-9134-e72f3098e2ae

@jorgeepc jorgeepc self-assigned this Dec 13, 2023
xoscar
xoscar approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

server/executor/trigger/traceid.go Outdated Show resolved Hide resolved
@jorgeepc jorgeepc marked this pull request as ready for review December 14, 2023 14:32
@jorgeepc jorgeepc merged commit ddb68b4 into main Dec 14, 2023
38 checks passed
@jorgeepc jorgeepc deleted the add-cypress-trigger-type branch December 14, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeepc @xoscar @danielbdias