Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable data store deletion on both CLI and Backend #3464

Merged
merged 4 commits into from
Dec 20, 2023
Merged

chore: disable data store deletion on both CLI and Backend #3464

merged 4 commits into from
Dec 20, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Dec 20, 2023 •
edited
Loading

This PR removes the data store deletion from the CLI and the API

Changes

  • Update Data Store RM to ignore deletion
  • Update CLI

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@danielbdias danielbdias marked this pull request as ready for review December 20, 2023 20:32
@danielbdias danielbdias merged commit 53c8990 into main Dec 20, 2023
37 checks passed
@danielbdias danielbdias deleted the disable-datastore-delete branch December 20, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@xoscar xoscar Awaiting requested review from xoscar

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbdias @mathnogueira