fix(cli): configure for non interactive environments #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schoren
commented
Feb 16, 2024
| c.finalServerURL = serverURL | ||
| if err != nil { | ||
| return err | ||
| c.flags = &flags |
There was a problem hiding this comment.
the original flags value was passed around in functions call, on top of being saved to the instance. this was confusing to follow and created 2 different copies of the same value, so modifications were almost impossible to track
All references to flags where replaced by c.flags and that in turn was converted to a pointer to allow modifications
danielbdias
approved these changes
Feb 16, 2024
schoren
commented
Feb 16, 2024
| @@ -17,12 +17,12 @@ type Entry struct { | |||
| func (c Configurator) organizationSelector(ctx context.Context, cfg Config, prev *Config) (string, error) { | |||
| resource, err := c.resources.Get("organization") | |||
| if err != nil { | |||
| return "", err | |||
| return "", fmt.Errorf("cannot create organizations client: %w", err) | |||
There was a problem hiding this comment.
some extra error info helped me debug the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on the CLI preventing the
configurecommand to work on automated environments. The command was asking for user input (asking for server) even when the--tokenflag was passed. This flag allows us to infer a non interactive environment so we can use a reasonable fallback (cloud url or previously configured value from config file) if no--server-urlis provided.On top of this, there was some incorrect handling of the flags within the configurator. Flags were saved as an instance variable by value instead of reference, so when one method modifies a flag value, the change is lost at the end of the function scope (see comments on PR)
Changes
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized