-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new devops agent for jdk11 #39
Conversation
@mangoGoForward: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -430,6 +430,9 @@ Agent: | |||
golang16: | |||
image: builder-go | |||
tag: v3.2.0-1.16 | |||
MavenJdk11: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a plan to refine the naming method in values.yaml for Jenkins chart, please see also #26.
So I suggest to change variable name MavenJdk11
to mavenJDK11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -243,6 +243,72 @@ data: | |||
securityContext: | |||
fsGroup: 1000 | |||
|
|||
- name: "mavenjdk11" | |||
namespace: "{{ .Values.Agent.WorkerNamespace }}" | |||
label: "maven" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two podTemplates that have the same label maven
. How to use jdk11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
charts/ks-devops/charts/jenkins/templates/jenkins-casc-config.yml
Outdated
Show resolved
Hide resolved
…erit from `maven` Merge remote-tracking branch 'upstream/master' into feat/jdk11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, LinuxSuRen, mangoGoForward The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR dose?
Add new pod template for Maven with JDK 11
What this PR does / why we need it:
please see #28.
Which issue(s) this PR fixes:
Fixes #28 .
How to test?
Pipeline script example: