Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support multi stop operate to stop workloads in workloads list #2480

Merged

Conversation

mangoGoForward
Copy link
Member

@mangoGoForward mangoGoForward commented Oct 18, 2021

What type of PR is this?

/kind feature
Hacktoberfest

What this PR does / why we need it:

When need to batch stop workloads in list, the operation is inconvenient

Which issue(s) this PR fixes:

Fixes #kubesphere/kubesphere#3544

Special notes for reviewers:

None

Does this PR introduced a user-facing change?

None

@ks-ci-bot
Copy link
Collaborator

@mangoGoForward: The label(s) kind/hacktoberfest cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind hacktoberfest

What this PR does / why we need it:

When need to batch stop workloads in list, the operation is inconvenient

Which issue(s) this PR fixes:

Fixes #kubesphere/kubesphere#3544

Special notes for reviewers:

None

Does this PR introduced a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-rebase labels Oct 18, 2021
@ks-ci-bot
Copy link
Collaborator

Hi @mangoGoForward. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Oct 18, 2021
@FeynmanZhou
Copy link
Member

It looks like there are conflicts in this PR.

@mangoGoForward
Copy link
Member Author

It looks like there are conflicts in this PR.

Ok, already to solved

@mangoGoForward
Copy link
Member Author

/assign @harrisonliu5

@FeynmanZhou
Copy link
Member

It looks like there are conflicts in this PR.

Ok, already to solved

Thanks for your contribution! @wansir @harrisonliu5 Could you pls help to review the updates?

@mangoGoForward
Copy link
Member Author

How can I add label "hacktoberfest" to participate in Hacktoberfest activity?

@harrisonliu5
Copy link
Contributor

harrisonliu5 commented Oct 18, 2021

/ok-to-test

@FeynmanZhou
Copy link
Member

How can I add label "hacktoberfest" to participate in Hacktoberfest activity?

How can I add label "hacktoberfest" to participate in Hacktoberfest activity?

Already added this label. Maybe you can try '/kind hacktoberfest-accepted' to add it for the follow-up PR.

@mangoGoForward
Copy link
Member Author

How can I add label "hacktoberfest" to participate in Hacktoberfest activity?

Already added this label. Maybe you can try '/kind hacktoberfest-accepted' to add it for the follow-up PR.

Thanks

@harrisonliu5
Copy link
Contributor

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f26d77c108b4e95127eb4af222ebcc925947d256

@harrisonliu5
Copy link
Contributor

/kind require-ui-text-review

@ks-ci-bot ks-ci-bot added the kind/require-ui-text-review Indicates that the UI text needs to be reviewed by the technical writing team. label Oct 18, 2021
@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, mangoGoForward

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@harrisonliu5
Copy link
Contributor

/cc @kubesphere/sig-testing

@harrisonliu5
Copy link
Contributor

/ok-to-test

@ks-ci-bot ks-ci-bot merged commit 3490588 into kubesphere:master Oct 18, 2021
@mangoGoForward mangoGoForward deleted the feature/batch-stop-workloads branch March 10, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. hacktoberfest hacktoberfest-accepted kind/feature Categorizes issue or PR as related to a new feature. kind/require-ui-text-review Indicates that the UI text needs to be reviewed by the technical writing team. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants