Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the branch column of pipeline list #2575

Merged

Conversation

mangoGoForward
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Number of branch should not be 0 if the Pipeline is not a multi-branch Pipeline

Which issue(s) this PR fixes:

Fixes #2499

Does this PR introduced a user-facing change?

None

@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Nov 1, 2021
@ks-ci-bot
Copy link
Collaborator

Hi @mangoGoForward. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member

/cc @kubesphere/sig-devops

@JohnNiang
Copy link
Member

/retitle Fix the branch column of pipeline list

@ks-ci-bot ks-ci-bot changed the title fix: Fix the branch column of pipeline list Fix the branch column of pipeline list Nov 1, 2021
@JohnNiang
Copy link
Member

/area devops

@harrisonliu5
Copy link
Contributor

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 280f5124ac77711c36fea35899c5c64915170b1f

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, mangoGoForward

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@ks-ci-bot ks-ci-bot merged commit f108e13 into kubesphere:master Nov 8, 2021
@harrisonliu5
Copy link
Contributor

/cherrypick release-3.2

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #2602

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops hacktoberfest-accepted kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of branch should not be 0 if the Pipeline is not a multi-branch Pipeline
6 participants