Fix the case where the value of the passed in parameter is empty when…

… running the Pipeline (#323) * Include parameters which value is empty Signed-off-by: John Niang <johnniang@fastmail.com> * Add a unit test against empty value only
kubesphere · Oct 21, 2021 · 9727751 · 9727751
1 parent 4271779
commit 9727751
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/pkg/kapis/devops/v1alpha3/pipelinerun/handler.go b/pkg/kapis/devops/v1alpha3/pipelinerun/handler.go
@@ -105,7 +105,7 @@ func (h *apiHandler) requestSyncPipelineRun(key client.ObjectKey) error {
 	return nil
 }
 
-func (h *apiHandler) createPipelineRuns(request *restful.Request, response *restful.Response) {
+func (h *apiHandler) createPipelineRun(request *restful.Request, response *restful.Response) {
 	nsName := request.PathParameter("namespace")
 	pipName := request.PathParameter("pipeline")
 	branch := request.QueryParameter("branch")

diff --git a/pkg/kapis/devops/v1alpha3/pipelinerun/register.go b/pkg/kapis/devops/v1alpha3/pipelinerun/register.go
@@ -32,7 +32,7 @@ func RegisterRoutes(ws *restful.WebService, c client.Client) {
 		Returns(http.StatusOK, api.StatusOK, v1alpha3.PipelineRunList{}))
 
 	ws.Route(ws.POST("/namespaces/{namespace}/pipelines/{pipeline}/pipelineruns").
-		To(handler.createPipelineRuns).
+		To(handler.createPipelineRun).
 		Doc("Create a PipelineRun for the specified pipeline").
 		Param(ws.PathParameter("namespace", "Namespace of the pipeline")).
 		Param(ws.PathParameter("pipeline", "Name of the pipeline")).

diff --git a/pkg/kapis/devops/v1alpha3/pipelinerun/util.go b/pkg/kapis/devops/v1alpha3/pipelinerun/util.go
@@ -47,7 +47,7 @@ func convertParameters(payload *devops.RunPayload) []v1alpha3.Parameter {
 	}
 	var parameters []v1alpha3.Parameter
 	for _, parameter := range payload.Parameters {
-		if parameter.Name == "" || parameter.Value == "" {
+		if parameter.Name == "" {
 			continue
 		}
 		parameters = append(parameters, v1alpha3.Parameter{

diff --git a/pkg/kapis/devops/v1alpha3/pipelinerun/util_test.go b/pkg/kapis/devops/v1alpha3/pipelinerun/util_test.go
@@ -159,6 +159,20 @@ func Test_convertParameters(t *testing.T) {
 			},
 		},
 		want: nil,
+	}, {
+		name: "Empty value only",
+		args: args{
+			payload: &devops.RunPayload{
+				Parameters: []devops.Parameter{{
+					Name:  "fakeName",
+					Value: "",
+				}},
+			},
+		},
+		want: []v1alpha3.Parameter{{
+			Name:  "fakeName",
+			Value: "",
+		}},
 	}, {
 		name: "Two parameters",
 		args: args{