Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ support add nodeEtcHosts entry #2298

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

will4j
Copy link
Contributor

@will4j will4j commented Jun 28, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support config custom hosts entry of cluster nodes.

For example, use config below to config harbor hosts entry:

spec:
  dns:
    nodeEtcHosts: |
      192.168.0.69  harbor.example.com

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Support spec.dns.nodeEtcHosts property to add node /etc/hosts entry.

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2024
@will4j
Copy link
Contributor Author

will4j commented Jun 28, 2024

/assign @pixiake

@pixiake
Copy link
Collaborator

pixiake commented Jul 5, 2024

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c946c40883d9009839f4f677fe94264023f52195

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, will4j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@ks-ci-bot ks-ci-bot merged commit eef9740 into kubesphere:master Jul 5, 2024
6 checks passed
@will4j will4j deleted the feature/node-etc-hosts branch August 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants