Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize build with diable unique keys #4114

Closed
wants to merge 1 commit into from

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Aug 3, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

The official version of kustomize returns errors when yaml contains duplicated keys. The reason is the upgrading package of go-yaml/yaml. I have had opened a pr to address this problem, but there was no response from the go-yaml maintainer. By the way, the last commit of go-yaml/yaml is at 2021-01-08, which is about eight months ago. Then I opened a pr to kubernetes-sigs/kustomize, the maintainer would wait to see what the go-yaml maintainer says. So I have to fork the repo kubernetes-sigs/kustomize, and add options to disable the unique keys. If the pr is closed, we will use the official version of kustomize.

https://github.com/kubesphere/kustomize/pull/1

Which issue(s) this PR fixes:

Fixes #3933

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@zryfish
Copy link
Member

zryfish commented Aug 3, 2021

That's a big change, I think we'd better fix it from upstream. Since there is a PR opened to go-yaml, maybe we can find a way to reach to go-yaml maintainers.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xyz-li
To complete the pull request process, please assign wansir after the PR has been reviewed.
You can assign the PR to them by writing /assign @wansir in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #4114 (9f385d0) into master (fa4c899) will decrease coverage by 1.58%.
The diff coverage is n/a.

❗ Current head 9f385d0 differs from pull request most recent head f0b2ab6. Consider uploading reports for the commit f0b2ab6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4114      +/-   ##
==========================================
- Coverage   28.11%   26.53%   -1.59%     
==========================================
  Files         217      217              
  Lines       22152    23448    +1296     
==========================================
- Hits         6228     6221       -7     
- Misses      14895    16180    +1285     
- Partials     1029     1047      +18     
Flag Coverage Δ
unittests 26.53% <ø> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mple/client/openpitrix/helmwrapper/helm_wrapper.go 23.29% <ø> (ø)
...ller/destinationrule/destinationrule_controller.go 36.81% <0.00%> (-10.00%) ⬇️
...controller/groupbinding/groupbinding_controller.go 62.67% <0.00%> (-2.12%) ⬇️
...g/controller/application/application_controller.go 65.51% <0.00%> (-2.07%) ⬇️
...controller/notification/notification_controller.go 52.08% <0.00%> (-0.61%) ⬇️
pkg/apiserver/config/config.go 55.55% <0.00%> (-0.41%) ⬇️
pkg/models/resources/v1alpha3/resource/resource.go 85.29% <0.00%> (-0.22%) ⬇️
pkg/models/openpitrix/utils.go 35.09% <0.00%> (-0.14%) ⬇️
pkg/models/monitoring/monitoring.go 0.00% <0.00%> (ø)
pkg/kapis/resources/v1alpha3/register.go 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4c899...f0b2ab6. Read the comment docs.

@xyz-li
Copy link
Contributor Author

xyz-li commented Aug 3, 2021

That's a big change, I think we'd better fix it from upstream. Since there is a PR opened to go-yaml, maybe we can find a way to reach to go-yaml maintainers.

I have sent message to the maintainer on twitter. Waiting for his response.

@xyz-li
Copy link
Contributor Author

xyz-li commented Aug 4, 2021

/hold

@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2021
Signed-off-by: LiHui <andrewli@kubesphere.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openpitrix installs app failed when helm chart contains duplicate keys.
3 participants