-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize build with diable unique keys #4114
Conversation
That's a big change, I think we'd better fix it from upstream. Since there is a PR opened to go-yaml, maybe we can find a way to reach to go-yaml maintainers. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xyz-li The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4114 +/- ##
==========================================
- Coverage 28.11% 26.53% -1.59%
==========================================
Files 217 217
Lines 22152 23448 +1296
==========================================
- Hits 6228 6221 -7
- Misses 14895 16180 +1285
- Partials 1029 1047 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I have sent message to the maintainer on twitter. Waiting for his response. |
/hold |
Signed-off-by: LiHui <andrewli@kubesphere.io>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The official version of kustomize returns errors when yaml contains duplicated keys. The reason is the upgrading package of go-yaml/yaml. I have had opened a pr to address this problem, but there was no response from the go-yaml maintainer. By the way, the last commit of go-yaml/yaml is at 2021-01-08, which is about eight months ago. Then I opened a pr to kubernetes-sigs/kustomize, the maintainer would wait to see what the go-yaml maintainer says. So I have to fork the repo kubernetes-sigs/kustomize, and add options to disable the unique keys. If the pr is closed, we will use the official version of kustomize.
https://github.com/kubesphere/kustomize/pull/1
Which issue(s) this PR fixes:
Fixes #3933
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: