Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧼 Fix Storybook errors and bump from 8.0.4 to 8.1.5 #1185

Merged

Conversation

sgratch
Copy link
Contributor

@sgratch sgratch commented Jun 2, 2024

Reference: #1177 (comment)

Bump Storybook version from 8.0.4 to latest 8.1.5 and fix Storybook compilation and lint errors.

Screenshots

Screenshot from 2024-06-02 22-21-08

Screencast.from.2024-06-02.22-23-39.webm

@sgratch sgratch force-pushed the fix-storybook-errors-and-bump-to-8.0.4 branch from 979fe8c to 363012f Compare June 2, 2024 19:37
@sgratch sgratch changed the title Fix Storybook errors and bump from 8.0.4 to 8.1.5 🐞 Fix Storybook errors and bump from 8.0.4 to 8.1.5 Jun 2, 2024
@sgratch sgratch force-pushed the fix-storybook-errors-and-bump-to-8.0.4 branch from 363012f to bb4eb48 Compare June 2, 2024 19:41
@sgratch sgratch requested a review from yaacov June 2, 2024 19:42
@sgratch sgratch force-pushed the fix-storybook-errors-and-bump-to-8.0.4 branch from bb4eb48 to c2ca83e Compare June 2, 2024 20:06
Reference: kubev2v#1177 (comment)

Bump Storybook version from 8.0.4 to latest 8.1.5 and fix Storybook compilation
and lint errors.

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@sgratch sgratch force-pushed the fix-storybook-errors-and-bump-to-8.0.4 branch from c2ca83e to 56ca910 Compare June 2, 2024 20:11
Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaacov yaacov added this to the 2.7.0 milestone Jun 3, 2024
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 3, 2024
@yaacov yaacov changed the title 🐞 Fix Storybook errors and bump from 8.0.4 to 8.1.5 🧼 Fix Storybook errors and bump from 8.0.4 to 8.1.5 Jun 3, 2024
@yaacov
Copy link
Member

yaacov commented Jun 3, 2024

@sgratch great, can you look into the ci issue ?

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending the ci issue

@yaacov yaacov merged commit 45e79a7 into kubev2v:main Jun 3, 2024
8 checks passed
@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jun 20, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants