Fix vSphere provider url help text field #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc:// @RichardHoch @anarnold97 |
yaacov
reviewed
Oct 1, 2023
...t-console-plugin/src/modules/Providers/views/create/components/VSphereProviderCreateForm.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Oct 1, 2023
...t-console-plugin/src/modules/Providers/views/create/components/VSphereProviderCreateForm.tsx
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
fix-vsphere-url-field-help-text
branch
from
847e94d
to
02c5a4f
Compare
ahadas
reviewed
Oct 3, 2023
packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
Outdated
Show resolved
Hide resolved
...t-console-plugin/src/modules/Providers/views/create/components/VSphereProviderCreateForm.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
Outdated
Show resolved
Hide resolved
...t-console-plugin/src/modules/Providers/views/create/components/VSphereProviderCreateForm.tsx
Outdated
Show resolved
Hide resolved
...t-console-plugin/src/modules/Providers/views/create/components/VSphereProviderCreateForm.tsx
Outdated
Show resolved
Hide resolved
|
I've proposed a different phrasing on #744 , please check it out before making changes here |
sgratch
force-pushed
the
fix-vsphere-url-field-help-text
branch
2 times, most recently
from
4f408ab
to
3288af3
Compare
|
@RichardHoch @ahadas your suggested changes were applied, please review |
ahadas
reviewed
Oct 3, 2023
| @@ -391,6 +390,7 @@ | |||
| "URL must start with https:// or http:// and contain valid hostname and path": "URL must start with https:// or http:// and contain valid hostname and path", | |||
| "URL of the provider": "URL of the provider", | |||
| "URL of the provider, leave empty to use this providers URL": "URL of the provider, leave empty to use this providers URL", | |||
| "URL of the vCenter SDK endpoint. Ensure the URL includes the \"/sdk\" path. for example: https://vCenter-host-example.com/sdk": "URL of the vCenter SDK endpoint. Ensure the URL includes the \"/sdk\" path. for example: https://vCenter-host-example.com/sdk", | |||
There was a problem hiding this comment.
Suggested change
| "URL of the vCenter SDK endpoint. Ensure the URL includes the \"/sdk\" path. for example: https://vCenter-host-example.com/sdk": "URL of the vCenter SDK endpoint. Ensure the URL includes the \"/sdk\" path. for example: https://vCenter-host-example.com/sdk", | |
| "URL of the vCenter SDK endpoint. Ensure the URL includes the \"/sdk\" path. For example: https://vCenter-host-example.com/sdk": "URL of the vCenter SDK endpoint. Ensure the URL includes the \"/sdk\" path. For example: https://vCenter-host-example.com/sdk", |
| @@ -412,7 +412,7 @@ | |||
| "vSphere REST API user name.": "vSphere REST API user name.", | |||
| "Warning concerns": "Warning concerns", | |||
| "Warning: The provided URL does not end with \"ovirt-engine/api\". Ensure it includes the correct path, like: https://rhv.com/ovirt-engine/api.": "Warning: The provided URL does not end with \"ovirt-engine/api\". Ensure it includes the correct path, like: https://rhv.com/ovirt-engine/api.", | |||
| "Warning: The provided URL does not end with \"sdk\". Ensure it includes the correct path, like: https://vcenter.com/sdk.": "Warning: The provided URL does not end with \"sdk\". Ensure it includes the correct path, like: https://vcenter.com/sdk.", | |||
| "Warning: The provided URL does not end with the SDK endpoint path: \"sdk\". Ensure the URL includes the correct path. For example: https://vCenter-host-example.com/sdk": "Warning: The provided URL does not end with the SDK endpoint path: \"sdk\". Ensure the URL includes the correct path. For example: https://vCenter-host-example.com/sdk", | |||
There was a problem hiding this comment.
nit-picking - we're not consistent here and also in #744 about the leading / in the path - here we don't have it (we say sdk) and below we have it (/sdk)
| 'Warning: The provided URL does not end with the SDK endpoint path: "sdk". Ensure the URL includes the correct path. For example: https://vCenter-host-example.com/sdk', | ||
| ), | ||
| success: t( | ||
| 'URL of the vCenter SDK endpoint. Ensure the URL includes the "/sdk" path. for example: https://vCenter-host-example.com/sdk', |
There was a problem hiding this comment.
Suggested change
| 'URL of the vCenter SDK endpoint. Ensure the URL includes the "/sdk" path. for example: https://vCenter-host-example.com/sdk', | |
| 'URL of the vCenter SDK endpoint. Ensure the URL includes the "/sdk" path. For example: https://vCenter-host-example.com/sdk', |
RichardHoch
approved these changes
Oct 4, 2023
|
LGTM with the changes Arik suggested ("F" instead of "f" where marked). |
sgratch
force-pushed
the
fix-vsphere-url-field-help-text
branch
from
3288af3
to
0910d72
Compare
|
@sgratch can you take care of the git conflicts ? |
As a followup for kubev2v#736, fix the vSphere provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "sdk/") as a valid url since it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch
force-pushed
the
fix-vsphere-url-field-help-text
branch
from
0910d72
to
9d96bf5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #646
As a followup for #736 , fix the vSphere provider's URL help text as follows:
Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations.
Set a url input ended with a "/" (i.e. "sdk/") as a valid url since it's a common use case.
Fix a bug in which the warning text message string (
helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly).Before the fix, the warning text was the same as the successful text:
After the fix, the warning text is displayed: