Fix the Edit URL modal text for the vSphere provider

[sgratch]

Reference: #646

Fix the Edit URL modal text for the vSphere provider, based on the create provider help texts:

1. Rephrase the title and help text field
2. Support warning text message and icon

Before the fix

After the fix

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sgratch]

cc:// @RichardHoch @anarnold97

[RichardHoch]

@sgratch @yaacov @anarnold97 @ahadas
After much discussion, the description for this field in the documentation was written as "URL of the SDK endpoint of the vCenter on which the source VM is mounted. Ensure that the URL includes the sdk path, usually /sdk. For example, https://vCenter-host-example.com/sdk. If a certificate for FQDN is specified, the value of this field needs to match the FQDN in the certificate."

Do I need to change the description in the documentation?

[yaacov]

@RichardHoch hi, thank you for noticing that,
no, me or @sgratch will align the UI to be as the docs in a followup PR

[ahadas]

note that with the introduction of "ESXi provider" we'd need to add another description for the case the URL refers to ESXi rather than to vCenter

[sgratch]

@RichardHoch @yaacov

hi, thank you for noticing that, no, me or @sgratch will align the UI to be as the docs in a followup PR

The current text is aligned with the one appears for the create provider modal.
IIRC, we agreed that the missing part which appears in the doc of "If a certificate for FQDN is specified, the value of this field needs to match the FQDN in the certificate", will not be displayed in UI since it's too detailed information.

Except that, there is nothing to change since we use the same terminology, just shorter.
If you still think we need a followup PR for this field (regardless to ESXi provider), please update here so that the fix won't be dragged to other providers text field changes as well.

[RichardHoch]

@sgratch Thanks for keeping me honest! :) In that case, everything's fine.

[yaacov]

The current text is aligned with the one appears for the create provider modal.
IIRC, we agreed that the missing part which appears in the doc of "If a certificate for FQDN is specified, the value of this field needs to match the FQDN in the certificate", will not be displayed in UI since it's too detailed information.

To clarify:
doc team (@RichardHoch ) decide on the the final text based on dev team ( @sgratch ) base inforamtion.
so in this case, the doc team looked at the original text and decided the final text should be some text, then that the text we should use.

Except that, there is nothing to change since we use the same terminology, just shorter.

when doc team (@RichardHoch ) decide on the text they took this into consideration, as dev team ( me ) we can advise, but the final text is what the doc team decide

[sgratch]

@yaacov @RichardHoch Sure! No argue about that.
My point is that We had that discussion when we rephrased the create providers URL text, based on the up to date doc. We decided it's ok to leave it as is and this PR for the edit providers is based on that as well.

If we want to rephrase those fields again and add more info or use the exact doc text in all relevant places for all providers, let's decide it now and I'll re-change it again in all places. I understood that the current text is ok back then.