🐾 Enhance OCP provider help text fields #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields Enhance and rephrase the help text fields and validations for following OCP dialogs: 1. Create OCP provider, 2. OCP Credentials view/edit modes. 3. OCP details - URL edit field 4. OCP details - URL title icon help text The changes includes supporting formatted help text. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
|
sgratch
changed the title
|
cc:// @RichardHoch @anarnold97 |
sgratch
changed the title
yaacov
changed the title
yaacov
added
the
enhancement
RichardHoch
reviewed
Jan 25, 2024
| @@ -8,6 +8,9 @@ | |||
| "{{selectedLength}} hosts selected.": "{{selectedLength}} hosts selected.", | |||
| "{{vmCount}} VMs selected ": "{{vmCount}} VMs selected ", | |||
| "{{vmDone}} of {{vmCount}} VMs migrated": "{{vmDone}} of {{vmCount}} VMs migrated", | |||
| "<br>A service account token with cluster admin privileges, required for authenticating the connection to the API server.": "<br>A service account token with cluster admin privileges, required for authenticating the connection to the API server.", | |||
| "<br>A service account token with cluster admin privileges, required for authenticating the connection to the API server.<br>If both <strong>URL</strong> and <strong>Service account bearer token</strong> are left blank, the local OpenShift cluster is used.": "<br>A service account token with cluster admin privileges, required for authenticating the connection to the API server.<br>If both <strong>URL</strong> and <strong>Service account bearer token</strong> are left blank, the local OpenShift cluster is used.", | |||
| "<br>Error: The format of the provided token is invalid. Ensure the token is a valid kubernetes service account token.": "<br>Error: The format of the provided token is invalid. Ensure the token is a valid kubernetes service account token.", | |||
RichardHoch
reviewed
Jan 25, 2024
| @@ -127,13 +130,12 @@ | |||
| "Error: The format of the provided CA Certificate is invalid. Ensure the CA certificate format is in a PEM encoded X.509 format.": "Error: The format of the provided CA Certificate is invalid. Ensure the CA certificate format is in a PEM encoded X.509 format.", | |||
| "Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and a path. For example: https://rhv-host-example.com/ovirt-engine/api.": "Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and a path. For example: https://rhv-host-example.com/ovirt-engine/api.", | |||
| "Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and a path. For example: https://vCenter-host-example.com/sdk.": "Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and a path. For example: https://vCenter-host-example.com/sdk.", | |||
| "Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and optionally a port. For example: <1>https://api.‹your-openshift-domain›:6443</1> .": "Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and optionally a port. For example: <1>https://api.‹your-openshift-domain›:6443</1> .", | |||
There was a problem hiding this comment.
"...name, and, optionally, a port." (appears twice)
RichardHoch
reviewed
Jan 25, 2024
| <Trans t={t} ns="plugin__forklift-console-plugin"> | ||
| { | ||
| 'Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and optionally a port. For example: ' | ||
| } |
There was a problem hiding this comment.
"...name, and, optionally, a port."
| } | ||
| <ExternalLink href="https://api.<your-openshift-domain>:6443" isInline hideIcon> | ||
| https://api.‹your-openshift-domain›:6443 | ||
| </ExternalLink> |
There was a problem hiding this comment.
"...name, and, optionally, a port."
| <span className="forklift-edit-modal-field-error-validation"> | ||
| <Trans t={t} ns="plugin__forklift-console-plugin"> | ||
| { | ||
| 'Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and optionally a port. For example: ' |
There was a problem hiding this comment.
"...name, and, optionally, a port."
| <Trans t={t} ns="plugin__forklift-console-plugin"> | ||
| { | ||
| '<br>Error: The format of the provided token is invalid. Ensure the token is a valid kubernetes service account token.' | ||
| } |
| <Trans t={t} ns="plugin__forklift-console-plugin"> | ||
| { | ||
| 'Error: The format of the provided URL is invalid. Ensure the URL includes a scheme, a domain name, and optionally a port. For example: ' | ||
| } |
There was a problem hiding this comment.
"...name, and, optionally, a port."
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Jan 25, 2024
A follow up for kubev2v#847 that includes the follwing fixes: - Fixing text fields based on doc team review. - Removing leading <br> tags from few text fields. - Replacing external links within the help text with formatted bolded text for url examples. - Making the help text fields shorter as possible, within one line. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #646
Enhance and rephrase the help text fields and validations for following OCP dialogs:
The changes include supporting formatted help text.
Screenshots: