Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: need support cron hpa #574

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Conversation

StevenLeiZhang
Copy link
Contributor

@StevenLeiZhang StevenLeiZhang commented Dec 28, 2022

Signed-off-by: StevenLeiZhang zhangleiic@163.com

fix:#573

Description of your changes

build one addon based on https://github.com/AliyunContainerService/kubernetes-cronhpa-controller

After addon installed, one new Trait is exposed, which is named "cronhpa". User could use it to set cronhpa for Component.

How has this code been tested?

test it locally.

  1. install it
cd experimental/addons/cronhpa
vale addon enable ./
  1. wait for it is up
    3.run test Application
cd examples/cronhpa
kubectl apply -f cronhpa-sample.yaml

  1. check the pod amount of helloworld Application.
    It will scale up and down every 30s.

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool works!

@StevenLeiZhang StevenLeiZhang force-pushed the cron-hpa branch 3 times, most recently from fc71217 to 28b99e1 Compare December 29, 2022 06:11
wangyikewxgm
wangyikewxgm previously approved these changes Dec 29, 2022
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add applyonce policy in example

Signed-off-by: StevenLeiZhang <zhangleiic@163.com>
@StevenLeiZhang
Copy link
Contributor Author

Please add applyonce policy in example

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants