Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon #603] Add Apache Spark as a experimental addon #629

Merged
merged 10 commits into from
Mar 7, 2023

Conversation

yanghua
Copy link
Contributor

@yanghua yanghua commented Feb 7, 2023

Signed-off-by: yanghua yanghua1127@gmail.com

Description of your changes

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@yanghua yanghua changed the title [Addon #603] Add Apache Spark as a experimental addon [WIP][Addon #603] Add Apache Spark as a experimental addon Feb 7, 2023
@wangyikewxgm
Copy link
Collaborator

Hi @yanghua , is this pr still in progress.

@yanghua
Copy link
Contributor Author

yanghua commented Feb 22, 2023

Hi @yanghua , is this pr still in progress.

Yes, considering Spark is a big engine and the Spark on Kubernetes operator provides a very comprehensive ability. I am still improving it and verifying it in our local env. Thanks for your patience.

@yanghua
Copy link
Contributor Author

yanghua commented Feb 27, 2023

Hi @wangyikewxgm I will provide a basic version of this addon. More advanced features would be iterated in the future. WDYT?

@yanghua yanghua marked this pull request as ready for review February 27, 2023 08:50
@wangyikewxgm wangyikewxgm changed the title [WIP][Addon #603] Add Apache Spark as a experimental addon [Addon #603] Add Apache Spark as a experimental addon Feb 27, 2023
@wangyikewxgm
Copy link
Collaborator

Hi @wangyikewxgm I will provide a basic version of this addon. More advanced features would be iterated in the future. WDYT?

OK,thanks for your contribution.

Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua yanghua force-pushed the KUBEVELA-CATALOG-603 branch from b492faa to 843319f Compare February 27, 2023 09:53
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
wangyikewxgm
wangyikewxgm previously approved these changes Mar 1, 2023
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution. Based on the successful enabling of this add-on and its clear and explicit introduction, I believe this PR is ready to be merged. In the future, we can make some optimizations for this addon, such as adding a topology rule configuration.

@yanghua
Copy link
Contributor Author

yanghua commented Mar 1, 2023

LGTM. Thank you for your contribution. Based on the successful enabling of this add-on and its clear and explicit introduction, I believe this PR is ready to be merged. In the future, we can make some optimizations for this add-on, such as adding a topology rule configuration.

Good suggestion, will iterate more advanced feature soon.

yanghua added 2 commits March 1, 2023 14:50
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
yanghua added 2 commits March 1, 2023 17:40
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua yanghua force-pushed the KUBEVELA-CATALOG-603 branch from 63165fe to 1c0cf18 Compare March 1, 2023 09:50
Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua yanghua force-pushed the KUBEVELA-CATALOG-603 branch from 043d7df to 8916021 Compare March 1, 2023 15:15
… and add spark-py example

Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua yanghua force-pushed the KUBEVELA-CATALOG-603 branch from 4b52ee4 to 7036a63 Compare March 2, 2023 08:17
… (add proxyUser option)

Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua
Copy link
Contributor Author

yanghua commented Mar 3, 2023

@wonderflow Any input about this PR?

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, ping @wangyikewxgm it would be better if we don't rely on kubectl in the readme of addons.

@wangyikewxgm wangyikewxgm merged commit 670b685 into kubevela:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants