Test: add tests for pkg/executor
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
FogDong
reviewed
Mar 20, 2023
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
FogDong
approved these changes
Mar 20, 2023
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
* Test: add tests Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Test: add tests for executor Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Test: add tests for executor Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * use for loop Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> --------- Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
* Test: add tests Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Test: add tests for executor Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Test: add tests for executor Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * use for loop Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> --------- Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
* Test: add tests Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Test: add tests for executor Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Test: add tests for executor Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * use for loop Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> --------- Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
pkg/executor, current test coverage93%executorlogsexecutor.RunJobssynchronousexeutorshutdown logic (usecontextto shutdown instead of called manually)Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer