Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add is-plain-object as a dependency #11

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

devholic
Copy link
Member

@devholic devholic commented Mar 15, 2022

It seems that the recent issue-commands workflow keeps failing.

This commit fixes this issue by adding is-plain-object as a dependency.

TODO


I tested with my personal repository

Signed-off-by: Sunghoon Kang hoon@linecorp.com

Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@wonderflow wonderflow merged commit 3f99556 into kubevela:main Mar 16, 2022
@devholic devholic deleted the is-plain-object branch March 16, 2022 02:06
wonderflow pushed a commit to kubevela/kubevela that referenced this pull request Mar 16, 2022
It seems that the `issue-commands` workflow keeps failing.

This commit fixes the `issue-commands` workflow by bumping up the
action version and replacing `npm install` with `npm ci` for
reproducibility.

Refs: kubevela/kubevela-github-actions#11

Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants