Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add InjectedIdentity for AWS Provider #294

Closed
wants to merge 8 commits into from

Conversation

s4rd1nh4
Copy link
Member

@s4rd1nh4 s4rd1nh4 commented Apr 18, 2022

Initial work for InjectedIdentity with IRSA. #293

TODO:

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #294 (2c449f2) into master (3b4fde8) will increase coverage by 0.26%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   81.84%   82.10%   +0.26%     
==========================================
  Files          19       19              
  Lines        1333     1358      +25     
==========================================
+ Hits         1091     1115      +24     
- Misses        174      175       +1     
  Partials       68       68              
Flag Coverage Δ
unit 82.10% <96.29%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/provider/credentials.go 91.83% <80.00%> (-0.64%) ⬇️
controllers/configuration_controller.go 77.23% <100.00%> (ø)
controllers/provider/aws.go 100.00% <100.00%> (ø)
controllers/rbac.go 91.13% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4fde8...2c449f2. Read the comment docs.

@s4rd1nh4 s4rd1nh4 changed the title Add InjectedIdentity for AWS Provider Draft: Add InjectedIdentity for AWS Provider Apr 18, 2022
Signed-off-by: s4rd1nh4 <diego.milhomes@gmail.com>
Signed-off-by: s4rd1nh4 <diego.milhomes@gmail.com>
Signed-off-by: s4rd1nh4 <diego.milhomes@gmail.com>
Signed-off-by: s4rd1nh4 <diego.milhomes@gmail.com>
@s4rd1nh4 s4rd1nh4 closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant