Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set default values for traits in VelaUX #912

Closed
wants to merge 1 commit into from

Conversation

am6737
Copy link
Contributor

@am6737 am6737 commented Oct 4, 2024

  • Addressed the issue where default values for traits (including "cpuscaler", "hpa", "resource", "k8s-update-strategy") were not being set properly.

Description of your changes

Fixes #650

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Traits with default values, such as "cpuscaler," "hpa," "resource," and "k8s-update-strategy," require some input to trigger the onChange event before the properties can be set correctly. To address this, I called onChange during the initialization phase to ensure the default values are set properly.

I realize that this approach may not be the most elegant solution, so I'm open to any suggestions for a better implementation or alternative ways to handle default values more effectively.

- Addressed the issue where default values for traits (including "cpuscaler", "hpa", "resource", "k8s-update-strategy") were not being set properly.

Signed-off-by: am6737 <1359816810@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] VelaUX does not set the default value of Trait "cpuscaler"
1 participant