Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2160298: Simplify YAML Switcher text to "YAML" #1019

Merged

Conversation

hstastna
Copy link

📝 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2160298

Simplify the text and use the regular font weight, not the bold one, according to the design changes.

🎥 Screenshots

Before:
When the switcher is off:
yaml_before1
When the switcher is on:
yaml_before2
After:
yaml_after1
yaml_after2

Simplify the text and use the regular font weight, not the bold one,
according to the design changes.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2160298
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

@hstastna: This pull request references Bugzilla bug 2160298, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2160298: Simplify YAML Switcher text to "YAML"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang January 16, 2023 17:43
@hstastna
Copy link
Author

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit cdb11c8 into kubevirt-ui:main Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2160298 has been moved to the MODIFIED state.

In response to this:

Bug 2160298: Simplify YAML Switcher text to "YAML"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants