Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2150832: Fix vCPU query in cluster overview metrics card #1030

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

pcbailey
Copy link
Member

📝 Description

This PR corrects the vCPU query in the cluster over metric charts to use count instead of sum and to use kubevirt_vmi_vcpu_wait_seconds instead of kubevirt_vmi_vcpu_seconds.

🎥 Screenshot

Selection_216

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@pcbailey: This pull request references Bugzilla bug 2150832, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2150832: Fix vCPU query in cluster overview metrics card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 27, 2023
@openshift-ci openshift-ci bot requested a review from gouyang January 27, 2023 13:45
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pcbailey
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 76d144e into kubevirt-ui:main Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@pcbailey: All pull requests linked via external trackers have merged:

Bugzilla bug 2150832 has been moved to the MODIFIED state.

In response to this:

Bug 2150832: Fix vCPU query in cluster overview metrics card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@pcbailey: new pull request created: #1032

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants