Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-21974: clone in progress label #1034

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jan 31, 2023

📝 Description

Forward also cloning DS and add label to them in the template list

Do you think other states will be added in the future? Maybe better to consider forwarding all the DS and filtering based on states later?

🎥 Demo

Before
Screenshot from 2023-01-31 17-48-32

After
Screenshot from 2023-01-31 17-48-41

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references CNV-21974 which is a valid jira issue.

In response to this:

📝 Description

Forward also cloning DS and add label to them in the template list

Do you think other states will be added in the future? Maybe better to consider forwarding all the DS and filtering based on states later?

🎥 Demo

Screenshot from 2023-01-31 17-48-41
Screenshot from 2023-01-31 17-48-32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references CNV-21974 which is a valid jira issue.

In response to this:

📝 Description

Forward also cloning DS and add label to them in the template list

Do you think other states will be added in the future? Maybe better to consider forwarding all the DS and filtering based on states later?

🎥 Demo

Before
Screenshot from 2023-01-31 17-48-32

After
Screenshot from 2023-01-31 17-48-41

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one question, otherwise looks good to me! 💪🏽

@upalatucci
Copy link
Member Author

/retest

@upalatucci upalatucci requested review from hstastna and removed request for yaacov and pcbailey February 3, 2023 12:59
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 3, 2023
@metalice
Copy link
Member

metalice commented Feb 5, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 47fed97 into kubevirt-ui:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants