Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2169224: Adding a check for getDay in metric virtualization #1037

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Bug 2169224: Adding a check for getDay in metric virtualization #1037

merged 1 commit into from
Feb 6, 2023

Conversation

metalice
Copy link
Member

@metalice metalice commented Feb 6, 2023

Signed-off-by: Matan Schatzman mschatzm@redhat.com

📝 Description

https://bugzilla.redhat.com/show_bug.cgi?id=2167251
virtualization overview crash. this fix prevents it.

🎥 Demo

Please add a video or an image of the behavior/changes

@metalice
Adding a check for getDay in metric virtualization
a0665f8 
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci openshift-ci bot requested review from avivtur and yaacov February 6, 2023 09:56
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 6, 2023
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dd9e4b3 into kubevirt-ui:main Feb 6, 2023
@tnisan tnisan requested a review from pcbailey February 6, 2023 15:25
@metalice metalice changed the title Adding a check for getDay in metric virtualization Bug 2169224: Adding a check for getDay in metric virtualization Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 2169224 has been moved to the MODIFIED state.

In response to this:

Bug 2169224: Adding a check for getDay in metric virtualization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2023
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@metalice: new pull request created: #1051

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Member Author

/cherry pick release-4.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivtur avivtur Awaiting requested review from avivtur

@yaacov yaacov Awaiting requested review from yaacov

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@upalatucci upalatucci

Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metalice @upalatucci @openshift-cherrypick-robot @openshift-merge-robot