Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move ensurePath to utils #1044

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

upalatucci
Copy link
Member

📝 Description

two ensurePath functions used all over the repo.

Just move it to utils

Copy link

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this refactoring, Ugo! We definitely needed to do this.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 9, 2023
@metalice
Copy link
Member

metalice commented Feb 9, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit c99943d into kubevirt-ui:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants