Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2168861: take namespace from vm instead of useParams #1053

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

upalatucci
Copy link
Member

📝 Description

Same thing as this pr but for sysprep instead of auth ssh.

useParams take params from the nearest route. HorizontalNav in this case instead of the global route So there is no ns parameter

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@upalatucci: This pull request references Bugzilla bug 2168861, which is invalid:

  • expected the bug to target the "4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2168861: take namespace from vm instead of useParams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@upalatucci: An error was encountered adding this pull request to the external tracker bugs for bug 2168861 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@upalatucci: An error was encountered searching for bug 2168861 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Get "https://bugzilla.redhat.com/rest/bug/2168861?include_fields=_default&include_fields=flags": net/http: TLS handshake timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@upalatucci: This pull request references Bugzilla bug 2168861, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang February 13, 2023 17:44
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit b18ca64 into kubevirt-ui:main Feb 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

@upalatucci: All pull requests linked via external trackers have merged:

Bugzilla bug 2168861 has been moved to the MODIFIED state.

In response to this:

Bug 2168861: take namespace from vm instead of useParams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: #1053 failed to apply on top of branch "release-4.12":

Applying: Bug 2168861: take namespace from vm instead of useParams
Using index info to reconstruct a base tree...
M	src/views/templates/details/tabs/scripts/components/SysPrepItem/SysPrepItem.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/views/templates/details/tabs/scripts/components/SysPrepItem/SysPrepItem.tsx
CONFLICT (content): Merge conflict in src/views/templates/details/tabs/scripts/components/SysPrepItem/SysPrepItem.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2168861: take namespace from vm instead of useParams
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants