Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-24126: Rearrange vm tabs #1067

Merged
merged 1 commit into from
Feb 22, 2023
Merged

CNV-24126: Rearrange vm tabs #1067

merged 1 commit into from
Feb 22, 2023

Conversation

metalice
Copy link
Member

@metalice metalice commented Feb 21, 2023 •
edited
Loading

📝 Description

We are rearranging tabs according to the new design.
https://docs.google.com/document/d/12VohNCqxqJP4TYzAO2WJvAYT3OPkfRGjez4rrRLuyZE/edit#heading=h.vcrz1bis83iy

🎥 Demo

image

@openshift-ci-robot
Copy link
Collaborator

@metalice: This pull request references CNV-24126 which is a valid jira issue.

In response to this:

📝 Description

We are rearranging tabs according to the new design.

🎥 Demo

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 21, 2023
@metalice
Copy link
Member Author

/retest

pcbailey
pcbailey reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the design document? I think part of the review should be checking the final result against the design to help each catch anything we may have missed.

src/utils/components/PendingChanges/utils/constants.ts Outdated
Diagnostic = 'Diagnostic',
// t('Configurations')
Configurations = 'Configurations',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be 'Configuration'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in the design its Configurations but you know English, lol. will change

@openshift-ci-robot
Copy link
Collaborator

@metalice: This pull request references CNV-24126 which is a valid jira issue.

In response to this:

📝 Description

We are rearranging tabs according to the new design.
https://docs.google.com/document/d/12VohNCqxqJP4TYzAO2WJvAYT3OPkfRGjez4rrRLuyZE/edit#heading=h.vcrz1bis83iy

🎥 Demo

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Member Author

Could you link to the design document? I think part of the review should be checking the final result against the design to help each catch anything we may have missed.

Added in the description the link

@metalice
Rearrange vm tabs
26fd62c 
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@upalatucci
Copy link
Member

upalatucci commented Feb 22, 2023 •
edited
Loading

/retest

for me its lgtm bt I would wait for Philip

@pcbailey
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2fdef8f into kubevirt-ui:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

@yaacov yaacov Awaiting requested review from yaacov

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@pcbailey pcbailey

Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metalice @openshift-ci-robot @upalatucci @pcbailey @openshift-merge-robot