Bug 2173527: Add help text to Machine type field #1101
Conversation
|
@hstastna: This pull request references Bugzilla bug 2173527, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add help text/popover to Machine type field present in the following places: - VM Details tab - VMI Details tab - VM Template Details tab - Customize VM flow (VM creation) Display the following info in the popover, when clicking on the dashed title of the field: "The machine type defines the virtual hardware configuration while the operating system name and version refer to the hypervisor." Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2173527
hstastna
force-pushed
the
BZ_Machine_type_field_popover
branch
from
c590583
to
d64696b
Compare
|
@hstastna: This pull request references Bugzilla bug 2173527, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2173527 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2173527
Add help text/popover with more info to Machine type field, present in the following places:
Display the following info in the popover, when clicking on the dashed title of the field:
"The machine type defines the virtual hardware configuration while the operating system name and version refer to the hypervisor."
🎥 Screenshots
Before:
No way to get some info about the _Machine type (VM Details page/tab):
After:
Clicking on the title of the Machine type field shows us more (VM Details page/tab):
Note that in other places, the result of adding the popover looks the same.