Bug 2175274: Display Edit CPU | Memory modal in VM Details #1105
Conversation
Fix the error, prevent blank page to be displayed, after trying to edit CPU/Memory of a VM, created from a template without "spec.template.spec.domain.cpu" defined in its VM object. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2175274
|
@hstastna: This pull request references Bugzilla bug 2175274, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2175274 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2175274
Fix the error, prevent blank page to be displayed, after trying to edit CPU/Memory of a VM, created from a template without
spec.template.spec.domain.cpudefined in its VM object (see the YAML of a VM or a Template).Fix the error by making sure the path exists (using
ensurePath), when editing the VM or Template object (the same problem occurs in more places).🎥 Demo
Before:
After:
