-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2168111: fix customize default source available #1164
Bug 2168111: fix customize default source available #1164
Conversation
@upalatucci: This pull request references Bugzilla bug 2168111, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...alog/templatescatalog/components/TemplatesCatalogDrawer/TemplatesCatalogDrawerCreateForm.tsx
Outdated
Show resolved
Hide resolved
8c570c9
to
9704b5f
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2168111 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
defaultSourceExists
should depend on justisBootSourceAvailable
instead ofcanQuickCreate
ascanQuickCreate
depends on required parameters with no default values andisBootSourceAvailable
.The template with no
defaultSourceAvailable
does not get default storage configuration in the customization as the template cannot start with the storage resource configured initially.But the template in the bug has the source available but has also a required parameter.
The user should be able to use default storage configuration when template has source available and required parameters