Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2168111: fix customize default source available #1164

Merged

Conversation

upalatucci
Copy link
Member

📝 Description

defaultSourceExists should depend on just isBootSourceAvailable instead of canQuickCreate as canQuickCreate depends on required parameters with no default values and isBootSourceAvailable.

The template with no defaultSourceAvailable does not get default storage configuration in the customization as the template cannot start with the storage resource configured initially.

But the template in the bug has the source available but has also a required parameter.

The user should be able to use default storage configuration when template has source available and required parameters

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

@upalatucci: This pull request references Bugzilla bug 2168111, which is invalid:

  • expected the bug to target the "4.14.0" release, but it targets "4.13.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2168111: fix customize default source available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 20, 2023
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit ba81f8d into kubevirt-ui:main Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@upalatucci: All pull requests linked via external trackers have merged:

Bugzilla bug 2168111 has been moved to the MODIFIED state.

In response to this:

Bug 2168111: fix customize default source available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants