Bug 2180279: VM cannot be started while creating from a template which has 2nd disk added

[avivtur]

📝 Description

Adding the namespace to the DataVolumeTemplate object causes issues and is not really necessary

🎥 Demo

After:

Peek.2023-03-22.15-45.mp4

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2180279, which is invalid:

• expected the bug to target the "4.14.0" release, but it targets "4.13.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2180279: VM cannot be started while creating from a template which has 2nd disk added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2180279, which is invalid:

• expected the bug to target the "4.14.0" release, but it targets "4.13.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2180279: VM cannot be started while creating from a template which has 2nd disk added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[metalice]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avivtur,metalice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[upalatucci]

Can the dataVolumeTemplate have also a different namespace? I think it can. I would copy also that info if it's in the metadata

[avivtur]

Can the dataVolumeTemplate have also a different namespace? I think it can. I would copy also that info if it's in the metadata

@upalatucci Hi
the dataVolumeTemplate is an array to create DataVolumes for the VM. you can't create a DV for a VM not in the same namespace, you can target the DV to be cloned from another DV/PVC that exists on another namespace if you have DV clone role binding.
So no it can't have a different namespace, I hope that makes sense to you

[upalatucci]

yes okay great

[openshift-ci]

@avivtur: All pull requests linked via external trackers have merged:

• kubevirt-ui/kubevirt-plugin#1181

Bugzilla bug 2180279 has been moved to the MODIFIED state.

In response to this:

Bug 2180279: VM cannot be started while creating from a template which has 2nd disk added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.