Update texts in Edit,Delete modals in Bootable volumes list #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update title of Delete modal, for a volume in Bootable volume list, change it to "Delete volume metadata?". Use "metadata" in the modal's text instead of "parameters". Update title for Edit modal, change it to "Edit volume metadata" (use "metadata" instead of "parameters" here, too). For consistency reasons, update also the subtitle for Edit button in Actions drop down (kebab menu) in Bootable volumes list to "You can edit bootable metadata". Make these updates according to the latest design changes.
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update title of Delete modal, for a volume in Bootable volumes list, change it to "Delete volume metadata?". Use "metadata" in the modal's text instead of "parameters".
Update title for Edit modal, change it to "Edit volume metadata" (use "metadata" instead of "parameters" here, too).
For consistency reasons, update also the subtitle for Edit button in Actions drop down (kebab menu) in Bootable volumes list to "You can edit bootable metadata".
Make these updates according to the latest design changes.
Design doc:
https://docs.google.com/document/d/15Cv54978AZKeukkurvkFN1YEx_kBsm_3XcmLey_cgZY/edit#heading=h.2mig9v8s38t
🎥 Screenshots
Before:
Subtitle for Edit button in Actions drop down:
Edit modal:
Delete modal:
After:
Subtitle for Edit button in Actions drop down:
Edit modal:
Delete modal: