Bug 2174744: Fix bootable volumes filter chips alignment

[pcbailey]

📝 Description

This PR fixes the misalignment of the filter chips on the InstanceTypes page.

🎥 Screenshots

Before

After

[openshift-ci]

@pcbailey: This pull request references Bugzilla bug 2174744, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.14.0) matches configured target release for branch (4.14.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2174744: Fix bootable volumes filter chips alignment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pcbailey]

@avivtur @metalice @upalatucci @hstastna @vojtechszocs PTAL

[hstastna]

The solution doesn't look as in other pages, like below, but it's definitely an improvement. The best would be this:

In your solution, there's still a bit more space above "Operating system" and the chips as it could be. IMO margin/padding top and bottom should have the same size (as in the picture above), so all the elements in the grey rectangle would be nicely centered (within the grey rectangle), not like this:

WDYT? Could we find some way to improve this even more (to reach the result as in the 1st picture I've added here)? 🙂

[pcbailey]

The scope of the bug is to fix the alignment of the filter chips, not the entire component. I'll fix the other issues in a separate PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hstastna,pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pcbailey: All pull requests linked via external trackers have merged:

• kubevirt-ui/kubevirt-plugin#1188

Bugzilla bug 2174744 has been moved to the MODIFIED state.

In response to this:

Bug 2174744: Fix bootable volumes filter chips alignment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pcbailey]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@pcbailey: new pull request created: #1212

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.