Bug 2158550: Display MigrationPolicy page after renaming correctly #1189
Conversation
Display MigrationPolicy details page or MigrationPolicies list correctly with no error, after changing the name of MigratiopPolicy. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2158550
openshift-ci
bot
added
bugzilla/severity-medium
bugzilla/valid-bug
approved
|
@hstastna: This pull request references Bugzilla bug 2158550, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2158550 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2158550
Display MigrationPolicy details page or MigrationPolicies list correctly with no error, after changing the name of some MigrationPolicy resource (depending on the actual location while renaming the policy).
More details:
The core of the problem was here where the original name of the policy was searched in the WHOLE URL and not at its end, where it belongs, so it was only logical that the first occurence of "a" was found "earlier" in the url string than expected and replaces by the new name, so "migraations" occurred in the url, that lead to the error, as such page wasn't found.
🎥 Screenshots
Before:
Error after renaming MigrationPolicy and incorrect url, especially if MigrationPolicy had a very simple name like "a":
URL:
/k8s/cluster/migraations.kubevirt.io~v1alpha1~MigrationPolicy/aAfter:
No error after renaming MigrationPolicy (to 'aa'), page rendered correctly:
URL:
/k8s/cluster/migrations.kubevirt.io~v1alpha1~MigrationPolicy/aa