Bug 2173525: Disk and net icons for boot order modal #1241
Conversation
|
@upalatucci: This pull request references Bugzilla bug 2173525, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
upalatucci
force-pushed
the
boot-modal-icons
branch
from
b6c5bf4
to
9bd2233
Compare
| type: DeviceType; | ||
| }; | ||
|
|
||
| export const DeviceTypeIconMapping = { |
There was a problem hiding this comment.
why export? maybe add a default value? why as const needed?
There was a problem hiding this comment.
I can remove the export and add a default value. The Volume Icon probably.
as const is useful. The object will be considered by typescript as immutable and will suggest the keys just like an enum
upalatucci
force-pushed
the
boot-modal-icons
branch
from
9bd2233
to
4169e6b
Compare
upalatucci
force-pushed
the
boot-modal-icons
branch
from
4169e6b
to
a782be8
Compare
|
@upalatucci: This pull request references Bugzilla bug 2173525, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upalatucci
force-pushed
the
boot-modal-icons
branch
from
a782be8
to
45390b5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2173525 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Adding icons for boot order modal
🎥 Demo
Before
After