CNV-28327: User settings hook infrastracture #1281
Conversation
|
@metalice: This pull request references CNV-28327 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metalice
force-pushed
the
CNV-28327-user-setting-intfrastructure
branch
from
3371740
to
1c83d3f
Compare
| useK8sWatchResource<IoK8sApiCoreV1ConfigMap>( | ||
| userName && { | ||
| groupVersionKind: modelToGroupVersionKind(ConfigMapModel), | ||
| namespace: 'default', |
There was a problem hiding this comment.
Hi :) can you please use const DEFAULT_NAMESPACE?
There was a problem hiding this comment.
done, same for the rest of the comments :)
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-28327-user-setting-intfrastructure
branch
from
1c83d3f
to
bfe7049
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This is the first step of adding the user setting feature.
In this PR I have built the hook that will be in charge of creating/updating the config map of user setting.
https://issues.redhat.com/browse/CNV-28327
🎥 Demo