Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-28334: Adding ability to user settings column management #1283

Conversation

metalice
Copy link
Member

@metalice metalice commented May 1, 2023

📝 Description

Updaing useKubevirtUserSettings (name and a bit refactor)
Adding new hook based on useKubevirtUserSettings to manage user selected columns that will be persistent among sessions and logins.
Connect VirtualMachineList to the new hook

A follow-up PR will connect the rest of the tables in our code base that use column management.

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci-robot
Copy link
Collaborator

@metalice: This pull request references CNV-28334 which is a valid jira issue.

In response to this:

📝 Description

Updaing useKubevirtUserSettings (name and a bit refactor)
Adding new hook based on useKubevirtUserSettings to manage user selected columns that will be persistent among sessions and logins.
Connect VirtualMachineList to the new hook

A follow-up PR will connect the rest of the tables in our code base that use column management.

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from upalatucci and yaacov May 1, 2023 13:42
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 1, 2023
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the CNV-28334-adding-ability-to-user-columns branch from 726fd16 to 4ef9538 Compare May 1, 2023 13:59
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member

avivtur commented May 2, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 47c28af into kubevirt-ui:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants