Add global state to VM create with IT

[avivtur]

📝 Description

Change Create VM from instance type flow to have a global state to avoid prop drilling and get a more maintainable code.

changes included in this PR:

• installing zustand - 3rd party lib for state management.
• moving the create VM from instance type to global state management - please use only in proper places (mostly under the CreateFromInstanceType component with some exceptions)

🎥 Demo

Please add a video or an image of the behavior/changes

[hstastna]

@avivtur Was adding another dependency necessary? What are the benefits of zustand comparing to the other solutions? And what is the problem we are trying to solve by this PR? Adding new dependency = a bit worse maintainable project. I am not telling that this is not good, I just want to know more about this PR and related decisions being made. Thanks.

[avivtur]

@avivtur Was adding another dependency necessary? What are the benefits of zustand comparing to the other solutions?

Hi @hstastna Thank you for looking :)
Since React has the context API, it's not 100% necesarry. However I've explored a state management solution, and consulting with @metalice we thought zustand has an easy-to-use API and needs less boilerplate code to manage it effectively than the context API, I invite you to explore yourself: https://github.com/pmndrs/zustand
it's also a highly maintained library with a very big community which is also supporting the open-source way :)

And what is the problem we are trying to solve by this PR? Adding new dependency = a bit worse maintainable project. I am not telling that this is not good, I just want to know more about this PR and related decisions being made. Thanks.

as written in the description, I wanted to centralize the state in one place, and avoid prop drilling (components sending props on to child just in the name of passing them as props as well).
adding one more dep to manage the state easily is not making the project less maintainable but the opposite, since we need less code to achieve something.

[metalice]

@avivtur Was adding another dependency necessary? What are the benefits of zustand comparing to the other solutions?

Hi @hstastna Thank you for looking :) Since React has the context API, it's not 100% necesarry. However I've explored a state management solution, and consulting with @metalice we thought zustand has an easy-to-use API and needs less boilerplate code to manage it effectively than the context API, I invite you to explore yourself: https://github.com/pmndrs/zustand it's also a highly maintained library with a very big community which is also supporting the open-source way :)

And what is the problem we are trying to solve by this PR? Adding new dependency = a bit worse maintainable project. I am not telling that this is not good, I just want to know more about this PR and related decisions being made. Thanks.

as written in the description, I wanted to centralize the state in one place, and avoid prop drilling (components sending props on to child just in the name of passing them as props as well). adding one more dep to manage the state easily is not making the project less maintainable but the opposite, since we need less code to achieve something.

Another big advantage is that it acts similarly to context, with the option to use multi-store and not central one-big-store, which is similar behavior as context.

[hstastna]

Thanks, guys, for the wider explanation, that's what I was looking for! 👍🏽

[pcbailey]

This is a great improvement! It makes things so much cleaner. I only have very minor comments.

[pcbailey]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avivtur,pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment