CNV-33095: add volumesnapshot option in the add bootable volume modal #1581
Conversation
|
@upalatucci: This pull request references CNV-33095 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@upalatucci: This pull request references CNV-33095 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upalatucci
force-pushed
the
create-volume-snapshot
branch
from
1c777cd
to
15c4947
Compare
src/utils/components/SelectSnapshot/SelectSnapshotNamespace.tsx
Outdated
Show resolved
Hide resolved
upalatucci
force-pushed
the
create-volume-snapshot
branch
from
15c4947
to
69b5a03
Compare
src/utils/components/SelectSnapshot/SelectSnapshotNamespace.tsx
Outdated
Show resolved
Hide resolved
upalatucci
force-pushed
the
create-volume-snapshot
branch
2 times, most recently
from
91eb6b7
to
73b4e5d
Compare
| snapshotsLoaded: boolean; | ||
| }; | ||
|
|
||
| export type VolumeSnapshotKind = K8sResourceCommon & { |
There was a problem hiding this comment.
if u are exporting a type better to put in a new tyhpes.ts near util, other components can consume it not from a hook file, just make it more organize
upalatucci
force-pushed
the
create-volume-snapshot
branch
from
73b4e5d
to
ed6d676
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Add the VoumeSnapshot option in the bootable volume.
With this option, we'll create a
DataSourcewithspec.source.snapshotUI is the same as the PVC option.
🎥 Demo