CNV-34895: Adding storage checkups #1598
Conversation
|
@metalice: This pull request references CNV-34895 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metalice
force-pushed
the
CNV-34895-storage-checkups
branch
2 times, most recently
from
488c620
to
90419e2
Compare
src/views/checkups/storage/components/hooks/useCheckupsStoragePermissions.ts
Outdated
Show resolved
Hide resolved
| const [activeTabKey, setActiveTabKey] = useState<number | string>( | ||
| history?.location?.pathname.endsWith('storage') ? 1 : 0, | ||
| ); | ||
|
|
||
| useEffect(() => { | ||
| history.push( | ||
| createURL(activeTabKey === 0 ? 'network' : 'storage', trimLastHistoryPath(history)), | ||
| ); | ||
| }, [activeTabKey, history, history?.location?.pathname]); | ||
|
|
||
| return ( | ||
| <> | ||
| <ListPageHeader title={t('Checkups')}> | ||
| <CheckupsRunButton {...props} /> | ||
| <CheckupsRunButton history={history} /> |
There was a problem hiding this comment.
Seems like network and storage can be defined as parameters in the path.
So that you can grab them using match.params from the RouteComponentProps props
Like /k8s/ns/:ns/checkups/:type/form. Would we insert other types of Checkups in the future?
There was a problem hiding this comment.
no plans for more right now.
it wont really give me anything adding :type as params, as each one is a different component, and console-extention is managing the lins and component according to links, except Checkups.tsx which function a bit as a router because of the tabs which I don't have a way around it.
src/views/checkups/storage/details/CheckupsStorageDetailsPageSection.tsx
Outdated
Show resolved
Hide resolved
src/views/checkups/storage/details/CheckupsStorageDetailsPageSection.tsx
Outdated
Show resolved
Hide resolved
src/views/checkups/storage/details/CheckupsStorageDetailsPageSection.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-34895-storage-checkups
branch
from
90419e2
to
d7615b5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Adding storage checkups is very similar to network checkups.
More info can be found here: https://github.com/kiagnose/kubevirt-storage-checkup
🎥 Demo