Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-35122: Adjust user name in configmap to uuid #1608

Conversation

metalice
Copy link
Member

📝 Description

We had a bug with username containing @ or other special chars that cannot used as keys in obj.
Now we will try to use uuid if user has one, all should have one except kube:admin, and rest we will replace special chars with dashes.

🎥 Demo

Please add a video or an image of the behavior/changes

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 15, 2023

@metalice: This pull request references CNV-35122 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.14.1" instead.

In response to this:

📝 Description

We had a bug with username containing @ or other special chars that cannot used as keys in obj.
Now we will try to use uuid if user has one, all should have one except kube:admin, and rest we will replace special chars with dashes.

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 15, 2023
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit a70b9b3 into kubevirt-ui:main Nov 15, 2023
8 checks passed
@metalice
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Collaborator

@metalice: new pull request created: #1615

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants