Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition column width #1614

Merged

Conversation

upalatucci
Copy link
Member

📝 Description

The table class changed from pf-c-table to pf-v5-c-table so we have to change also the scss here

🎥 Demo

Before

Screenshot from 2023-11-22 09-41-53
Screenshot from 2023-11-22 09-41-47

After

Screenshot from 2023-11-22 09-44-42

@openshift-ci openshift-ci bot requested a review from metalice November 22, 2023 08:50
@openshift-ci openshift-ci bot requested a review from yaacov November 22, 2023 08:50
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 22, 2023
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 22, 2023
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f96bdee into kubevirt-ui:main Nov 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants