Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-28017: Removing details tab - adding to configuraiton tab #1621

Merged

Conversation

metalice
Copy link
Member

@metalice metalice commented Nov 30, 2023

📝 Description

same pr as #1619

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 30, 2023

@metalice: This pull request references CNV-28017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

Add a brief description

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 30, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 30, 2023

@metalice: This pull request references CNV-28017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

📝 Description

same pr as #1619

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 30, 2023
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the cNV-28017-removing-details-tab branch from baa40c2 to f82b610 Compare November 30, 2023 13:29
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Nov 30, 2023
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 30, 2023
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b20a5c7 into kubevirt-ui:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants