CNV-37382: Inconsistency between the cluster settings and VM settings for SSH over LoadBalancer

[avivtur]

📝 Description

This bug is introducing a few problematic behaviors:

1. Under Overview > Settings > Cluster > General settings > SSH configurations we have a switch to toggle the option of SSH over LB inside the VM's Configuration > SSH tab. If the metalLB operator is installed, the option inside the VM is always selectable no matter what state the switch has.

2. If the metalLB operator was installed in the cluster, then uninstalled, we still show as the operator is installed (the ssh over LB inside the VM is still selectable

The solution includes a tighter check if metalLB is installed, and if so we disable the switch as on.

🎥 Demo

###Before:

After:

MetalLB is installed:

MetalLB is NOT installed:

switch is on:

switch is off:

[openshift-ci-robot]

@avivtur: This pull request references CNV-37382 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This bug is introducing a few problematic behaviors:

1. Under Overview > Settings > Cluster > General settings > SSH configurations we have a switch to toggle the option of SSH over LB inside the VM's Configuration > SSH tab. If the metalLB operator is installed, the option inside the VM is always selectable no matter what state the switch has.

2. If the metalLB operator was installed in the cluster, then uninstalled, we still show as the operator is installed (the ssh over LB inside the VM is still selectable

The solution includes a tighter check if metalLB is installed, and if so we disable the switch as on.

🎥 Demo

###Before:

After:

MetalLB is installed:

MetalLB is NOT installed:

switch is on:

switch is off:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[avivtur]

/jira refresh

[openshift-ci-robot]

@avivtur: This pull request references CNV-37382 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "CNV v4.16.0" instead.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[metalice]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avivtur,metalice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment