Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37821: Make column management for Preferences list work #1782

Conversation

hstastna
Copy link

@hstastna hstastna commented Feb 6, 2024

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-37821

Make the column management responsible on saved changes by providing the correct id for columnLayout prop of the ListPageFilter component used in the related list page.

Note:
The saved change in the column management modal will be lost if the user leaves the page and returns back, unfortunately. To make this work as expected, #1779 must be merged, too.! Needs more code changes to make it work 100%.

🎥 Demo

Before:

pref_before.mp4

After:

pref_after.mp4

Make the column management responsible on saved changes by providing
the correct id for "columnLayout" prop of the "ListPageFilter"
component used in the related list page.

Fixes https://issues.redhat.com/browse/CNV-37821
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 6, 2024

@hstastna: This pull request references CNV-37821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-37821

Make the column management responsible on saved changes by providing the correct id for columnLayout prop of the ListPageFilter component used in the related list page.

Note:
The saved change in the column management modal will be lost if the user leaves the page and returns back, unfortunately. To make this work as expected, #1779 must be merged, too.

🎥 Demo

Before:

pref_before.mp4

After:

pref_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 6, 2024
@hstastna
Copy link
Author

hstastna commented Feb 6, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 7, 2024

@hstastna: This pull request references CNV-37821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-37821

Make the column management responsible on saved changes by providing the correct id for columnLayout prop of the ListPageFilter component used in the related list page.

Note:
The saved change in the column management modal will be lost if the user leaves the page and returns back, unfortunately. To make this work as expected, #1779 must be merged, too.!

🎥 Demo

Before:

pref_before.mp4

After:

pref_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna
Copy link
Author

hstastna commented Feb 7, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

1 similar comment
@hstastna
Copy link
Author

hstastna commented Feb 9, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 9, 2024

@hstastna: This pull request references CNV-37821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-37821

Make the column management responsible on saved changes by providing the correct id for columnLayout prop of the ListPageFilter component used in the related list page.

Note:
The saved change in the column management modal will be lost if the user leaves the page and returns back, unfortunately. To make this work as expected, #1779 must be merged, too.! Needs more code changes to make it work 100%.

🎥 Demo

Before:

pref_before.mp4

After:

pref_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 9, 2024
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hstastna,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dcbc42f into kubevirt-ui:main Feb 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants