-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-37821: Make column management for Preferences list work #1782
CNV-37821: Make column management for Preferences list work #1782
Conversation
Make the column management responsible on saved changes by providing the correct id for "columnLayout" prop of the "ListPageFilter" component used in the related list page. Fixes https://issues.redhat.com/browse/CNV-37821
@hstastna: This pull request references CNV-37821 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
@hstastna: This pull request references CNV-37821 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
1 similar comment
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
@hstastna: This pull request references CNV-37821 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-37821
Make the column management responsible on saved changes by providing the correct
id
forcolumnLayout
prop of theListPageFilter
component used in the related list page.Note:
The saved change in the column management modal will be lost if the user leaves the page and returns back, unfortunately.
To make this work as expected, #1779 must be merged, too.!Needs more code changes to make it work 100%.🎥 Demo
Before:
pref_before.mp4
After:
pref_after.mp4