-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-37575: Add save button to the environment sidebar editor #1788
CNV-37575: Add save button to the environment sidebar editor #1788
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
/jira refresh |
/cherry-pick release-4.15 |
@gouyang: new pull request created: #1829 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
The issue is related to the
onEditChange={setDisableVmCreate}
This callback should disable the
Create
button in the wizard but this the trigger a re-loading.I would remove that behaviour at this point as we do not do that in other tabs.
the sidebar editor triggers a VM update at the beginning and everytime we change something in the editor.
Instead of using
onChange
we should useonResourceUpdate
. It will show the Save button on the bottom like in all the other tabs. Clicking on the save button will trigger the reloading of the EnvironmentForm.🎥 Demo