Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double {{count}} #1808

Merged

Conversation

upalatucci
Copy link
Member

📝 Description

Remove double {{count}} in translations
Create singular and plural depends on _one and _other translations. Those translations can be edited anyways by us.

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 20, 2024
@openshift-ci openshift-ci bot added lgtm Passed code review, ready for merge do-not-merge/hold and removed do-not-merge/hold labels Feb 20, 2024
@avivtur
Copy link
Member

avivtur commented Feb 20, 2024

/hold
Holding until upgrade to PF5 is completed

@upalatucci
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Feb 28, 2024
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 29, 2024
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hstastna,metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e65cb37 into kubevirt-ui:main Feb 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants