CNV-38577: Fix initial load of serial console #1812
Conversation
|
@metalice: This pull request references CNV-38577 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
metalice
force-pushed
the
CNV-38577-serial-console-is-on-initial-load
branch
from
2501cff
to
f415d36
Compare
metalice
force-pushed
the
CNV-38577-serial-console-is-on-initial-load
branch
from
f415d36
to
17056e1
Compare
| } | ||
|
|
||
| if (isClusterDisabledGuestSystemLogs) { | ||
| return <Bullseye>{t('Guest system logs are disabled at cluster')}</Bullseye>; | ||
| } | ||
|
|
||
| if (isNeededRestart || !isPodLogContainerExist) { | ||
| return <Bullseye>{t('Guest system access logs not ready. a restart required')}</Bullseye>; |
There was a problem hiding this comment.
Why are you adding this string here? Just recently it was suggested to me to use "Restart required" instead of "a restart required". And the sentence should start with a big letter.. Maybe you've just accidentally copied here the older version of this string?
There was a problem hiding this comment.
Probably beause moved the IF check and it took the string before. anyway changed
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-38577-serial-console-is-on-initial-load
branch
from
17056e1
to
3c47fc4
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, hstastna, metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.15 |
|
@metalice: new pull request created: #1839 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
The initial setting of the serial console wasn't loaded into the features config map.
More checks were added to tell if the VM needs to restart after enabling the setting in cluster scope.
🎥 Demo
Before:
as can be seen in the photos in the bug report https://issues.redhat.com/browse/CNV-38577
After:
