Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PF5 glitches - part 2 #1836

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Mar 7, 2024

📝 Description

Fixing some minor glitches from PF5 upgrade

🎥 Demo

Before:
No-checkboxes-in-row-filters
RemoveFilterIcon-b4
ListPageFilterNotScrollable
device-name-dropdown-b4

After:
No-checkboxes-in-row-filters-aft
RemoveFilterIcon
ListPageFilterScrollable
device-name-dropdown

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot requested review from pcbailey and yaacov March 7, 2024 15:20
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 7, 2024
@metalice
Copy link
Member

metalice commented Mar 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aaf6248 into kubevirt-ui:main Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants